Avoid using protected members outside scope #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates elastic#838
hub-cap
added
the
cleanup
46 tasks
There was a problem hiding this comment.
@hub-cap you have a conflict here to resolve.
Whilst disabling warnings for tests makes sense, have we checked we can't mitigate some of these by just exposing accessors for the variables?
|
The way I look at it, since these are almost all tests,. it doesn't make a ton of sense to expose members for them. Looks like there are a few new things to clean up, im working on them now. |
|
@hub-cap see #1106 (review) why this maybe failed. @danielmitterdorfer corrected the reference |
gingerwizard
reviewed
Nov 5, 2020
esrally/track/params.py
Outdated
| self.template_definitions.append((template.name, body)) | ||
| else: | ||
| raise exceptions.InvalidSyntax("Please set the properties 'template' and 'body' for the " | ||
| f"{params.get('operation-type')} operation or declare composable and/or component " | ||
| "templates in the track") | ||
|
|
||
| @staticmethod | ||
| def _create_or_merge(content, path, new_content): | ||
| def create_or_merge(self, content, path, new_content): |
There was a problem hiding this comment.
I don't think we need to do this anymore - See #1106
esrally/track/params.py
Outdated
| return original_content | ||
|
|
||
| @staticmethod | ||
| def __merge(dct, merge_dct): | ||
| def merge(self, dct, merge_dct): |
|
I reverted the code for that, ty @gingerwizard for the pointer. |
gingerwizard
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we reenable the pylint check
W0212which checkswhether protected members are used outside of their classes scope.
Relates #838